Skip to content

Fix unread badge clearing all sessions when any chat is opened#17045

Merged
ndoschek merged 1 commit intomasterfrom
nd/improve-unread-card-state
Feb 24, 2026
Merged

Fix unread badge clearing all sessions when any chat is opened#17045
ndoschek merged 1 commit intomasterfrom
nd/improve-unread-card-state

Conversation

@ndoschek
Copy link
Member

What it does

  • Move unread tracking from React useState (lost on unmount) into the ChatSessionsWelcomeMessageProvider service so state persists across welcome screen mount/unmount cycles
  • Only clear the unread flag for the specific session that is activated, not all sessions
  • Show "Unread" badge in the session card hover tooltip
  • Clean up unread state when a session is deleted

How to test

  • Verify the unread state persists for the chat cards until it is actually read. Currently if you open an chat all unread states are reset.
  • Verify the chat card tooltip now also shows an unread badge if a chat has unread messages

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@ndoschek ndoschek requested a review from sgraband February 24, 2026 09:19
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Feb 24, 2026
- Move unread tracking from React useState (lost on unmount) into the  ChatSessionsWelcomeMessageProvider service so state persists across welcome screen mount/unmount cycles
- Only clear the unread flag for the specific session that is activated, not all sessions
- Show "Unread" badge in the session card hover tooltip
- Clean up unread state when a session is deleted
@ndoschek ndoschek force-pushed the nd/improve-unread-card-state branch from f4b5bb0 to 844abde Compare February 24, 2026 09:24
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM 👍

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Feb 24, 2026
@ndoschek ndoschek merged commit e97b3f2 into master Feb 24, 2026
10 checks passed
@ndoschek ndoschek deleted the nd/improve-unread-card-state branch February 24, 2026 10:07
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Feb 24, 2026
@github-actions github-actions bot added this to the 1.69.0 milestone Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants