Skip to content

build: add missing test dependencies to package workspaces to fix lint warnings #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
18bharathkumar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

build: add missing test dependencies to package workspaces to fix lint warnings #1461

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4937909
build: add missing test dependencies to package workspaces to fix lin…
18bharathkumar Jan 11, 2026
6034fde
Fix monorepo dependency hoisting and ESLint extraneous-dependencies rule
18bharathkumar Jan 12, 2026
c3ca5be
Merge branch 'eclipse-thingweb:master' into fix/lint-extraneous-depen…
18bharathkumar Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export default defineConfig([
"n/hashbang": "warn",

// *************** Ensure that only used dependencies are imported ***************
"extraneous-dependencies/no-extraneous-dependencies": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"extraneous-dependencies/no-extraneous-dependencies": "warn", // https://github.com/eclipse-thingweb/node-wot/issues/1430
Copy link
Member

@danielpeintner danielpeintner Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extraneous-dependencies/no-extraneous-dependencies": "warn", // https://github.com/eclipse-thingweb/node-wot/issues/1430
"extraneous-dependencies/no-extraneous-dependencies": "warn",

Copy link
Member

@danielpeintner danielpeintner Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I propose to remove the Github link


// *************** Code style and best practices ***************
"unused-imports/no-unused-imports": "error",
Expand Down
47 changes: 44 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions packages/binding-coap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
"slugify": "^1.4.5",
"wot-typescript-definitions": "0.8.0-SNAPSHOT.31"
},
"devDependencies": {
"@testdeck/mocha": "^0.1.2",
"chai": "^4.3.4"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
3 changes: 3 additions & 0 deletions packages/binding-file/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
"@node-wot/core": "0.9.2",
"rxjs": "^5.5.11"
},
"devDependencies": {
"chai": "^4.3.4"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
8 changes: 7 additions & 1 deletion packages/binding-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@
"body-parser": "^1.20.3",
"express": "^4.20.0",
"ssestream": "^1.1.0",
"timekeeper": "^2.2.0"
"timekeeper": "^2.2.0",
"@testdeck/mocha": "^0.1.2",
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1",
"chai-spies": "^1.0.0",
"serve-static": "^1.16.2",
"@sinonjs/fake-timers": "^7.1.2"
},
"dependencies": {
"@node-wot/core": "0.9.2",
Expand Down
4 changes: 4 additions & 0 deletions packages/binding-mbus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
"node-mbus": "^2.2.6",
"rxjs": "^5.5.11"
},
"devDependencies": {
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
4 changes: 4 additions & 0 deletions packages/binding-modbus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
"rxjs": "^5.5.11",
"wot-typescript-definitions": "0.8.0-SNAPSHOT.31"
},
"devDependencies": {
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
4 changes: 4 additions & 0 deletions packages/binding-mqtt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
"mqtt": "^5.3.2",
"rxjs": "^5.5.11"
},
"devDependencies": {
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
2 changes: 2 additions & 0 deletions packages/binding-netconf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
},
"keywords": [],
"devDependencies": {
"chai": "^4.3.4",
"chai-spies": "^1.0.0",
"@types/node-netconf": "npm:@types/netconf@^2.0.0",
"@types/url-parse": "^1.4.3"
}
Expand Down
4 changes: 4 additions & 0 deletions packages/binding-websockets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
"slugify": "^1.4.5",
"ws": "^7.5.10"
},
"devDependencies": {
"@testdeck/mocha": "^0.1.2",
"chai": "^4.3.4"
},
"scripts": {
"build": "tsc -b",
"test": "mocha --require ts-node/register --extension ts",
Expand Down
2 changes: 2 additions & 0 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@
"homepage": "https://github.com/eclipse-thingweb/node-wot/tree/master/packages/cli#readme",
"keywords": [],
"devDependencies": {
"@testdeck/mocha": "^0.1.2",
"chai": "^4.3.4",
"@types/lodash": "^4.14.199"
}
}
10 changes: 9 additions & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,15 @@
"@types/content-type": "^1.1.8",
"@types/debug": "^4.1.7",
"@types/uritemplate": "^0.3.4",
"@types/uuid": "^8.3.1"
"@types/uuid": "^8.3.1",
"@testdeck/mocha": "^0.1.2",
"@types/chai": "^4.2.18",
"@types/chai-as-promised": "^7.1.4",
"@types/chai-spies": "^1.0.4",
"@types/mocha": "^10.0.10",
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1",
"chai-spies": "^1.0.0"
},
"dependencies": {
"@petamoriken/float16": "^3.1.1",
Expand Down
Loading