Terminate the hid interrupt out endpoint on deactivate #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@eclipse-threadx/iot-threadx-committers, I need a volunteer with porting expertise to review this contribution. |
Contributor
|
This looks like up your alley, @rahmanih. Do you think you could review this contribution? |
Contributor
|
Do you think you will be able to look at this, @rahmanih? |
Nictrla
force-pushed
the
terminate-hid-endpoint
branch
from
6ec3038 to
2a1acfd
Compare
|
@fdesbiens the point is valid and can be merged |
ABOUSTM
approved these changes
Jun 4, 2025
|
This is a bug we also encountered. The solution is fine, but I would add an additional safeguard with an if statement, because even with the preprocessor flag enabled, there might be an instance without out_ep, since it's optional |
Contributor
|
@pjgorgon you are right it optional endpoint, @fdesbiens can you merge this PR since it was approved by commuter I will make another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint is not properly closed and reopened, when unplugging / re-plugging the USB connector (on a device with a second power source and no VBUS detection).
This causes issues receiving data on the HID out endpoint by Interrupt transfer.