Fix trace server version and display #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <[email protected]>
The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match. Signed-off-by: Bernd Hufmann <[email protected]>
fixes eclipse-tracecompass-incubator#121 Signed-off-by: Bernd Hufmann <[email protected]>
MatthewKhouzam
approved these changes
Nov 19, 2024
Contributor
MatthewKhouzam
left a comment
MatthewKhouzam
left a comment
There was a problem hiding this comment.
Good catch for versioning.
bhufmann
merged commit d91785a
into
eclipse-tracecompass-incubator:master
1 check passed
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The rest.core plug-in version is retrieved to show in the identifier service. This is the only way to retrieve the version programmatically and hence the plug-in version and release version has to match.
fixes #121
Signed-off-by: Bernd Hufmann [email protected]