Sign 3rd party artifacts with Trace Compass's PGP key #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
gpg-signing
branch
from
5fc560c to
85be90f
Compare
This will get the latest code for gpg signing. Fix compiler errors reported due to new tycho version. Signed-off-by: Bernd Hufmann <[email protected]>
Both Trace Compass Inbubator update site, RCP update site and trace server update site will be signed. Use tycho-gpg-plugin: https://tycho.eclipseprojects.io/doc/4.0.11/tycho-gpg-plugin/sign-p2-artifacts-mojo.html Signing of RCP/Trace Server update site requires Tycho 4.0.10 or later. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
gpg-signing
branch
from
85be90f to
6bae74e
Compare
PatrickTasse
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Sign 3rd party artifacts with Trace Compass's PGP key. Both Trace Compass Incubator update site, RCP update site and trace server update site will be signed.
Use tycho-gpg-plugin:
https://tycho.eclipseprojects.io/doc/4.0.11/tycho-gpg-plugin/sign-p2-artifacts-mojo.html
Upgrade to Tycho 4.0.11 because signing of RCP update site requires Tycho 4.0.10 or later. The new Tycho required changes to to fix compiler errors reported by new Tycho version.
How to test
The changes were copied from eclipse-tracecompass/org.eclipse.tracecompass#224 where it was thoroughly tested.
Follow-ups
Review checklist
Signed-off-by: Bernd Hufmann [email protected]