Allow double and remove boolean in OutputElementStyle (type of property values) #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only float values were allowed. Don't restrict to float and allow Double as well. Note when deserializing JSON strings a floating point value will be deserialized to Double, e.g. when using Jackson deserializer (Java) or in Javascript. Remove boolean because it can be expressed as String and boolean have no equivalent type in CSS where the StyleProperties are inspired of. Contributes to: eclipse-cdt-cloud/trace-server-protocol#102 Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
requested changes
May 29, 2025
| assertTrue(deserialized.getStyleValues().isEmpty()); | ||
| } | ||
|
|
||
| private static void veryStyles(OutputElementStyle testStyle, OutputElementStyleStub deserialized) { |
| gen.writeStringField("parentKey", value.getParentKey()); | ||
|
|
||
| // Verify the type of style values. Make sure only supported types are returned. | ||
| Map<String, Object> newValues = new HashMap<>(); |
Contributor
There was a problem hiding this comment.
Maybe could use startObject/writeField/endObject pattern to write directly without needing copied map, and preserve original map order.
Contributor
Author
There was a problem hiding this comment.
Ok. This will avoid looping through the map multiple times. The order doesn't really matter, unless the input map is a LinkedHashMap that preserves the insertion order.
bhufmann
changed the title
Merged
1 task
bhufmann
added a commit
to bhufmann/trace-server-protocol
that referenced
this pull request
May 29, 2025
Previously only float values were allowed. Don't restrict to float and allow Double as well. Note when deserializing JSON strings a floating point value will be deserialized to Double, e.g. when using Jackson deserializer (Java) or in Javascript. Remove boolean because it can be expressed as String and boolean have no equivalent type in CSS where the StyleProperties are inspired of. Contributes to: eclipse-cdt-cloud#102 Corresponding swagger model update: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#192 Signed-off-by: Bernd Hufmann <[email protected]>
This will make sure that only objects that comply with the TSP specification are serialized. Added unit tests to verify this. eclipse-cdt-cloud/trace-server-protocol#102 Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
approved these changes
May 29, 2025
bhufmann
merged commit dad714c
into
eclipse-tracecompass-incubator:master
2 checks passed
bhufmann
added a commit
to eclipse-cdt-cloud/trace-server-protocol
that referenced
this pull request
May 29, 2025
Previously only float values were allowed. Don't restrict to float and allow Double as well. Note when deserializing JSON strings a floating point value will be deserialized to Double, e.g. when using Jackson deserializer (Java) or in Javascript. Remove boolean because it can be expressed as String and boolean have no equivalent type in CSS where the StyleProperties are inspired of. Contributes to: #102 Corresponding swagger model update: eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#192 Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
swagger: Allow double and remove boolean in OutputElementStyle
Previously only float values were allowed. Don't restrict to float and allow Double as well. Note when deserializing JSON strings a floating point value will be deserialized to Double, e.g. when using Jackson deserializer (Java) or in Javascript. Remove boolean because it can be expressed as String and boolean have no equivalent type in CSS where the StyleProperties are inspired of.
server: Only serialize supported value types in OutputElementStyle
This will make sure that only objects that comply with the TSP specification are serialized. Added unit tests to verify this.
Contributes to:
eclipse-cdt-cloud/trace-server-protocol#102
How to test
Successful execution of newly added test case
Follow-ups
TSP spec. update
Review checklist