server: fix swagger documentation for generic xy endpoint #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
previously approved these changes
Aug 20, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
PatrickTasse
requested changes
Aug 20, 2025
| @JsonSubTypes({ | ||
| @JsonSubTypes.Type(value = AxisDomainCategorical.class, name = "categorical"), | ||
| @JsonSubTypes.Type(value = AxisDomainTimeRange.class, name = "timeRange") | ||
| @JsonSubTypes.Type(value = AxisDomainRange.class, name = "range") |
Contributor
There was a problem hiding this comment.
The change from 'timeRange' to 'range' should also be applied to the AxisDomainSerializer.
- Fixed "xValuesDescription" and "yValuesDescription" to show XYAxisDescription instead of arrays. - Renamed "AxisDomainTimeRange" to "AxisDomainRange" to show that it is not only for time ranges. Previously "IAxisDomain.TimeRange" was renamed to "IAxisDomain.Range" but swagger documentation wasn't updated accordingly.
siwei-zhang-work
force-pushed
the
fix-doc-genericxy
branch
from
226df14 to
900ad12
Compare
PatrickTasse
approved these changes
Aug 21, 2025
Contributor
|
The build error is unrelated. I'll go ahead and merge it. I keep on eye on the build. |
bhufmann
merged commit 0cae21c
into
eclipse-tracecompass-incubator:master
1 of 5 checks passed
Contributor
It turns out that the error was caused by this PR. I missed that and should not have merged the PR. PR #217 fixes the build issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It fixes problems in swagger documentation introduced in:#203
How to test
Start the server and browse to http://localhost:8080/tsp/api/openapi.yaml
Follow-ups
No follow-ups.
Review checklist