server: Fix incorrect duplicate trace path detection on Windows #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use NIO instead to create Path for old and new trace path in order to compare them. Fixes eclipse-tracecompass-incubator#214 Signed-off-by: Bernd Hufmann <[email protected]>
PatrickTasse
approved these changes
Aug 28, 2025
bhufmann
merged commit c995e3e
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Use NIO instead to create Path for old and new trace path in order to compare them, which compares case insensitive.
Fixes #214
Note: I tested on Windows and Linux
How to test
Open a trace multiple times, will open the same trace everytime and won't import it under a different name. On Linux the behaviour will be as before, but in Windows the bug is fixed.
Follow-ups
Review checklist