swagger: Fix supported types of TimeGraphEntry metadata values #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
bugfix4tsp_tg_entry
branch
from
04d2fca to
c212439
Compare
PatrickTasse
approved these changes
Aug 28, 2025
PatrickTasse
requested changes
Aug 28, 2025
| Map<String, Collection<MetadataValue>> getMetadata(); | ||
|
|
||
| /** | ||
| * Type for metadata values (String, Float, Integer or Boolean) |
Contributor
There was a problem hiding this comment.
Is this correct? Doesn't match the oneOf below.
bhufmann
force-pushed
the
bugfix4tsp_tg_entry
branch
from
c212439 to
836dbca
Compare
PatrickTasse
previously approved these changes
Aug 28, 2025
fixes eclipse-cdt-cloud/trace-server-protocol#129 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
bugfix4tsp_tg_entry
branch
from
836dbca to
d5788e6
Compare
PatrickTasse
approved these changes
Aug 28, 2025
bhufmann
merged commit d14a8dc
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
swagger: Fix supported types of TimeGraphEntry metadata values
fixes eclipse-cdt-cloud/trace-server-protocol#129
How to test
Verify generated openapi.yaml (https://github.com/eclipse-cdt-cloud/trace-server-protocol?tab=readme-ov-file#generate-the-api)
Follow-ups
TSP specification update
Review checklist