server.tests: Use generated TSP java client in all existing unit tests #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
FIXME: isFiltered flag for selection stats is not part of TSP Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
java-gen-tests
branch
from
833b0c3 to
4c670fd
Compare
PatrickTasse
requested changes
Oct 15, 2025
| /** | ||
| * XY API | ||
| */ | ||
| private static XyApi sfxyApi = new XyApi(sfApiClient); |
Contributor
There was a problem hiding this comment.
sfXyApi? and should be static final?
| return Long.valueOf(callstackOptional.get().getId()).intValue(); // TODO | ||
| // ID | ||
| // is | ||
| // long |
Contributor
Author
There was a problem hiding this comment.
Done. I actually replaced by a FIXME with link to the issue tracker: // FIXME eclipse-cdt-cloud/trace-server-protocol#140. I've done in both the xy and timegraph tests.
The following issues were identified and need fixes. eclipse-tracecompass-incubator#235 eclipse-tracecompass-incubator#213 eclipse-tracecompass-incubator#236 eclipse-cdt-cloud/trace-server-protocol#140 There is a workaround for eclipse-tracecompass-incubator#236 implemented that ignores the issue, but needs to be fixed to test the xy series models. Signed-off-by: Bernd Hufmann <[email protected]>
Needed fix: eclipse-tracecompass-incubator#240 eclipse-cdt-cloud/trace-server-protocol#140 Signed-off-by: Bernd Hufmann <[email protected]>
Needs fix for: eclipse-tracecompass-incubator#246 Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
Signed-off-by: Bernd Hufmann <[email protected]>
needs the following fix to fix the FIXME: eclipse-tracecompass-incubator#236 Signed-off-by: Bernd Hufmann <[email protected]>
Disable MapperFeature.ALLOW_COERCION_OF_SCALARS so that StateValue.deserialize() only tries to deserialize the received type and not the others, which would cause a parse exception. Signed-off-by: Bernd Hufmann <[email protected]>
Needs fix to be able to fix FIXME: eclipse-tracecompass-incubator#236 Signed-off-by: Bernd Hufmann <[email protected]>
After all tests having been migrated the class can be renamed to the original name. Signed-off-by: Bernd Hufmann <[email protected]>
They have been replaced by the generated TSP java client in plugin: org.eclipse.tracecompass.incubator.tsp.client.core Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
java-gen-tests
branch
from
4c670fd to
9a56e16
Compare
PatrickTasse
approved these changes
Oct 16, 2025
bhufmann
merged commit 88b0297
into
eclipse-tracecompass-incubator:master
2 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Use generated TSP java client in all existing unit tests. The generated Java TSP client is introduced by PR #228.
RestServerTests#executePostErrorTests) which would have cause a lot copied code to do the same calls but with different input and output classes and apis.Note: Multiple issues have been indentified and some have been already fixed.
Note: Fix for #236 is needed to properly test the
SeriesModelsqueries of testsGenericXYDataProviderServiceTest,XyDataProviderServiceTestandSeriesModelSerializerTest. In this PR those tests ignore parsing errors (see FIXMEs)How to test
Successful CI run. Make sure that all unit tests are executed successfully.
Follow-ups
Add more test cases to validate more TSP models returned during queries.
Review checklist