server.tests: Regenerate Java TSP client and XY fix tests#254
Merged
bhufmann merged 1 commit intoeclipse-tracecompass-incubator:masterfrom Oct 23, 2025
Merged
Conversation
Fix for eclipse-tracecompass-incubator#236 required a regeneration of the Java TSP client and caused changes in the API that required the XY tests to be fixed. Remove SamplingSerializer and SamplingSerializerTest because it's part of SeriesModelSerializer and SeriesModelSerializerTest respectively. Set flag failOnUnknownProperties when generating Java TSP client which helps with detecting correct class for deserialization especially for oneOf cases, e.g. oneOf AxisDomainCategorical, AxisDomainRange. Set hideGenerationTimestamp flag to true since generation timestamp can be derived from the git history. Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
java-gen-tests-fixed-sampling
branch
from
0d608ea to
c09f438
Compare
PatrickTasse
approved these changes
Oct 23, 2025
bhufmann
merged commit 9e5ae20
into
eclipse-tracecompass-incubator:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fix for #236 required a regeneration of the Java TSP client and caused changes in the API that required the XY tests to be fixed.
Remove
SamplingSerializerandSamplingSerializerTestbecause it's part ofSeriesModelSerializerandSeriesModelSerializerTestrespectively.Set flag
failOnUnknownPropertieswhen generating Java TSP client which helps with detecting correct class for deserialization especially foroneOfcases, e.g.oneOf AxisDomainCategorical, AxisDomainRange.Set
hideGenerationTimestampflag to true since generation timestamp can be derived from the git history.How to test
Verify that updated tests in this PR run successfully (part of CI):
Follow-ups
N/A
Review checklist