profiling: cache symbol key interval #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To resolve symbols, the method retrieveSymbolKeyAt will query a symbol key attribute for every interval in a query2d. This create a significant overhead that can easily be avoided if we cache this interval. For all current use cases, the symbol key interval is unique for each trace. Signed-off-by: Arnaud Fiorini <[email protected]>
MatthewKhouzam
approved these changes
Dec 10, 2024
Contributor
MatthewKhouzam
left a comment
MatthewKhouzam
left a comment
There was a problem hiding this comment.
Looks great, can I have a trace before and after? I would love to play with execution comparisons.
Contributor
Author
bhufmann
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve symbols, the method retrieveSymbolKeyAt will query a symbol key attribute for every interval in a query2d. This creates a significant overhead that can easily be avoided if we cache this interval. For all current use cases, the symbol key interval is unique for each trace.