tmf: add capabilities data structure to IDataProviderDescriptor #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
dp-capabilities
branch
from
65e6287 to
bea09a6
Compare
PatrickTasse
requested changes
Jan 7, 2025
| * "canCreate" and "canDelete" capability. | ||
| * | ||
| * "canCreate" indicates that a given data provider can create a derived data | ||
| * provider. "canDelete" indicates that a the data provider can be deleted. |
Contributor
There was a problem hiding this comment.
Just to make sure, "canDelete" indicates that THIS data provider can be deleted, it is not related to deleting derived data providers that this data provider has created, correct? So it's the derived data providers that would have their own "canDelete" set to true?
Contributor
Author
There was a problem hiding this comment.
yes, the derived data provide would set canDelete to true and not the parent data provider.
| * Sets canDelete flag | ||
| * | ||
| * @param canDelete | ||
| * true if data provider can create a derived data provider |
With this a data provider factory instance can advertise special capabilities that can be applied for the given data provider. This commit adds code for that and implements the "canCreate" and "canDelete" capability. "canCreate" indicates that this instance can create a derived data provider. Use the IDataProviderFactory method getAdapter(ITmfDataProviderConfigurator.class) to obtains an instance of ITmfDataProviderConfigurator. This interface has methods to get List<ITmfConfigurationSourceType> describing the parameters needed to create a derived data provider using method ITmfDataProviderConfigurator#createDataProvider. "canDelete" indicates a the data provider can be deleted using method ITmfDataProviderConfigurator#deleteDataProviderDescriptor. [Added] capabilities data structure to IDataProviderDescriptor Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
dp-capabilities
branch
from
bea09a6 to
636e79d
Compare
PatrickTasse
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this a data provider factory instance can advertise special capabilities that can be applied for the given data provider.
This commit adds code for that and implements the "canCreate" and "canDelete" capability. "canCreate" indicates that this instance can create a derived data provider. Use the IDataProviderFactory method getAdapter(ITmfDataProviderConfigurator) to obtains a ITmfDataProviderConfigurator. This interface has methods to get List describing the parameters needed to create a derived data provider using method createDataProvider.
"canDelete" indicates a the data provider can be deleted using the method ITmfDataProviderConfigurator#deleteDataProviderDescriptor.
[Added] capabilities data structure to IDataProviderDescriptor
see also eclipse-cdt-cloud/theia-trace-extension#1158
Signed-off-by: Bernd Hufmann [email protected]