releng: Bundle java runtime in Trace Compass RCP product packages #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
force-pushed
the
bundled-java
branch
2 times, most recently
from
5a93711 to
e4667d7
Compare
PatrickTasse
requested changes
Feb 12, 2025
| <repository location="https://download.eclipse.org/justj/jres/17/updates/release/17.0.14/"/> | ||
| <unit id="org.eclipse.justj.openjdk.hotspot.jre.minimal.stripped.feature.group" version="0.0.0"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit"> |
| @@ -1,6 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.31" sequenceNumber="6"> | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.31" sequenceNumber="8"> | |||
| @@ -1,6 +1,10 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.33" sequenceNumber="4"> | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.33" sequenceNumber="7"> | |||
| @@ -1,6 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.34" sequenceNumber="5"> | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="tracecompass-e4.34" sequenceNumber="7"> | |||
Update target files to include JustJ JREs https://eclipse.dev/justj/ with respective version for that release. Use latest available JRE version for respective major version. This will make it easier for end-users to use Trace Compass because Java doesn't need to be installed separately and it will include the correct, required version. Notes: - The stripped version of the JRE is used with debug information stripped and excluding the src.jar with sources used only for debugging. This minimizes the size of the JRE package because it's less than 1/2 the size of the corresponding full version. If you'd like to debug the RCP (e.g. using remote debugging), use a separated JVM as described below. - To run the RCP with a different JVM (e.g. installed on user's laptop), open the tracecompass.ini file and modify the path settings for -vm. Or remove it completely then the default JRE of the computer is used. Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
force-pushed
the
bundled-java
branch
from
e4667d7 to
9b318a3
Compare
PatrickTasse
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Bundle JustJ JVM inside the Trace Compass RCP packages.
Update target files to include JustJ JREs with respective version for that release. Use latest available JRE version for respective major version.
This will make it easier for end-users to use Trace Compass because Java doesn't need to be installed separately and it will include the correct, required version.
Notes:
tracecompass.inifile and modify the path stettings for-vm. Or remove it completely then the default JRE of the computer is used.How to test
Build and run the RCP. Check in configuration (
Help -> About... -> Installation Details -> Configuration) the bundled JRE is used.Follow-ups
N/A
Review checklist