Upgrade to Java 21 #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Tasse <[email protected]>
bhufmann
requested changes
Jan 10, 2025
Contributor
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
It think we should build for java 8 JVM and just make sure that it works when running with newer JVMs. Otherwise only applications that use java 21 can use it.
Contributor
MatthewKhouzam
left a comment
MatthewKhouzam
left a comment
There was a problem hiding this comment.
Can you make a lambda getThreadID() that uses reflection to get the right method, have it stored globally as GET_THREAD_ID or something like that?
Contributor
|
I think this one can be closed, @PatrickTasse right? |
Contributor
|
Closing it. Please reopen it needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.