feat: bring your own wallet #1422

leandro-cavalcante · 2025-07-23T12:43:48Z

Description

As a part of Bring Your Own Wallet (BYOW) efforts within the Catena-X to decentralize the wallet ecosystem in the network, it is necessary for some of the Tractus-X components (i.e., Portal Backend, ssi-credential-issuer) to foster this movement.

Onboarding Processes must be adapted for portal backend and frontend

Why

Enabling the decentralization of the wallets within the Catena-X network
Avoiding clientID / secret sharing between organizations (Operating Company and Network Participant)

Issue

Link to Github issue 1160.

Checklist

Please delete options that are not relevant.

I have followed the contributing guidelines
I have created and linked IP issues or requested their creation by a committer
I have performed a self-review of my own code
I have successfully tested my changes locally
I have added tests that prove my changes work
I have checked that new and existing tests pass locally with my changes
I have commented my code, particularly in hard-to-understand areas

src/administration/Administration.Service/BusinessLogic/BringYourOwnWalletBusinessLogic.cs

src/externalsystems/UniversalDidResolver.Library/UniversalDidResolverService.cs

tests/externalsystems/BpnDidResolver.Library.Tests/BpnDidResolverBusinessLogicTests.cs

tests/externalsystems/UniversalDidResolver.Library.Tests/UniversalDidResolverServiceTest.cs

...gistration/Registration.Service.Tests/BusinessLogic/BringYourOwnWalletBuisinessLogicTests.cs

typecastcloud

Some formatting issues I found. Also please take a look at codeql findings.

src/registration/Registration.Service/BusinessLogic/BringYourOwnWalletBusinessLogic.cs

src/registration/Registration.Service/Controllers/BringYourOwnWalletController.cs

...istration/Administration.Service.Tests/BusinessLogic/BringYourOwnWalletBusinessLogicTests.cs

...externalsystems/UniversalDidResolver.Library.Tests/UniversalDidResolver.Library.Tests.csproj

src/Portal.Backend.sln

src/registration/Registration.Service/BusinessLogic/BringYourOwnWalletBusinessLogic.cs

src/externalsystems/UniversalDidResolver.Library/UniversalDidResolverService.cs

src/administration/Administration.Service/BusinessLogic/RegistrationBusinessLogic.cs

src/externalsystems/UniversalDidResolver.Library/UniversalDidResolverService.cs

src/externalsystems/UniversalDidResolver.Library/Schemas/DidDocument.schema.json

src/portalbackend/PortalBackend.DBAccess/Repositories/CompanyRepository.cs

...istration/Administration.Service.Tests/BusinessLogic/BringYourOwnWalletBusinessLogicTests.cs

tests/externalsystems/IssuerComponent.Library.Tests/IssuerComponentBusinessLogicTests.cs

tests/externalsystems/Bpdm.Library/BpdmBusinessLogicTests.cs

dhiren-singh-007

I have done the review and approving the PR.
@ntruchsess Can you please have a look also?

src/registration/Registration.Service/BusinessLogic/RegistrationBusinessLogic.cs

src/registration/Registration.Service/Registration.Service.csproj

Co-authored-by: Shumaila Malik <[email protected]> Co-authored-by: Nitin <[email protected]>

…ion business logic

Co-authored-by: Karsten Thiems <[email protected]>

This reverts commit bb0a4ad.

This reverts commit 1ef3e66.

src/administration/Administration.Service/BusinessLogic/TechnicalUserBusinessLogic.cs

sonarqubecloud · 2025-07-31T13:33:50Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarQube Cloud

MaximilianHauer · 2025-08-01T08:44:11Z

as aligned in the portal meeting @ntruchsess will start the review as soon as possible

old

saadanzari · 2025-11-11T09:41:32Z

@MaximilianHauer @ntruchsess can we pls close this ticket? or do you still want to review or add anything?
cc @leandro-cavalcante @dhiren-singh-007

github-project-automation bot added this to Portal Jul 23, 2025

leandro-cavalcante requested review from Phil91 and dhiren-singh-007 July 23, 2025 12:43

leandro-cavalcante self-assigned this Jul 23, 2025

github-advanced-security bot found potential problems Jul 23, 2025

View reviewed changes

typecastcloud previously requested changes Jul 23, 2025

View reviewed changes

github-project-automation bot moved this to IN PROGRESS in Portal Jul 23, 2025

saloniGargFEDev mentioned this pull request Jul 23, 2025

feat: modify helm chart config for byow eclipse-tractusx/portal#555

Open

2 tasks

typecastcloud added this to the Release 25.09 milestone Jul 24, 2025

typecastcloud added the enhancement New feature or request label Jul 24, 2025

dhiren-singh-007 reviewed Jul 25, 2025

View reviewed changes

leandro-cavalcante mentioned this pull request Jul 25, 2025

Refactor DIM business logic to use UniversalDidService for Did Validation #1428

Open

3 tasks

github-advanced-security bot found potential problems Jul 27, 2025

View reviewed changes

tests/externalsystems/Bpdm.Library/BpdmBusinessLogicTests.cs Fixed Show fixed Hide fixed

dhiren-singh-007 previously approved these changes Jul 30, 2025

View reviewed changes

dhiren-singh-007 requested a review from typecastcloud July 30, 2025 07:45

leandro-cavalcante dismissed dhiren-singh-007’s stale review via feb8b55 July 30, 2025 07:50

leandro-cavalcante requested a review from ntruchsess July 30, 2025 07:52

typecastcloud reviewed Jul 30, 2025

View reviewed changes

src/registration/Registration.Service/BusinessLogic/RegistrationBusinessLogic.cs Show resolved Hide resolved

src/registration/Registration.Service/Registration.Service.csproj Outdated Show resolved Hide resolved

leandro-cavalcante and others added 12 commits July 30, 2025 17:45

feat: Changed onboard to add the wallet from the company (#3)

7bac059

feat: add support for bring your own wallet in issuer credentials

d2f9081

feat: CS 3640 add controller to validate did (#2)

f84b87a

Co-authored-by: Shumaila Malik <[email protected]> Co-authored-by: Nitin <[email protected]>

Added step to trasmit the did to other systems

8ca45df

Added the correct step during on board process for byow

ba0b20f

Updated the updated bpn to also check BYOW

9f72fef

Created an endpoint to save the did number and refoctor the registrat…

d977609

…ion business logic

removed uncessary parameter on the endpoint byow

5471731

Added necessary parameter for resolver did

181c966

Extracting correct did http address and enhanced tests

72db6bf

fix: added check for missing configuration

da15c32

fix: added implementation to avoid duplicate dids

cf36b5b

leandro-cavalcante and others added 14 commits July 30, 2025 17:45

Update src/Portal.Backend.sln

b69f2d3

Co-authored-by: Karsten Thiems <[email protected]>

fix: resolved codeql findings

25f452b

fix: resolved pr requests

349c717

fix: removed codeql warning for user-controlled data

56a214c

Revert "fix: removed codeql warning for user-controlled data"

de3fa2c

This reverts commit bb0a4ad.

fix: removed codeql warning for user-controlled data

08f5c49

fix: removed user-controlled bypass sensitive method

3b16134

Revert "fix: removed user-controlled bypass sensitive method"

163cbee

This reverts commit 1ef3e66.

fix: enhanced the use of exceptions and updated tests

67ec43e

fix: split tests to cover pr review

2155ea9

fix: added logic on bpdm business logic when byow active

02b031b

fix: adding the standard format for the path of the library

58aac7d

fix: added starndard format to the path of the library

34a263b

fix: Revert automatic formatting

9b1f62e

leandro-cavalcante force-pushed the feat/Bring_Your_Own_Wallet branch from 0c67cbf to 9b1f62e Compare July 30, 2025 15:50

leandro-cavalcante added 5 commits July 31, 2025 09:44

fix: updating the dependencies file

ef01fbe

fix: updating the depencies file generated fom pipeline

0f7e410

fix: filtering possible unauthorized user role provided by the user

e135f43

fix: fixing user bypass control during user role validation

320ab71

fix: refactoring the code to avoid user bypass controller

4e0a47b

github-advanced-security bot found potential problems Jul 31, 2025

View reviewed changes

src/administration/Administration.Service/BusinessLogic/TechnicalUserBusinessLogic.cs Fixed Show fixed Hide fixed

fix: combined if statements

ce4bf72

dhiren-singh-007 approved these changes Aug 1, 2025

View reviewed changes

typecastcloud added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label Aug 4, 2025

typecastcloud modified the milestones: Release 25.09, Release 25.12 Aug 4, 2025

feat: bring your own wallet #1422

Are you sure you want to change the base?

feat: bring your own wallet #1422

Uh oh!

Conversation

leandro-cavalcante commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Why

Issue

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

typecastcloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhiren-singh-007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 31, 2025

Quality Gate passed

Uh oh!

MaximilianHauer commented Aug 1, 2025

Uh oh!

saadanzari commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

leandro-cavalcante commented Jul 23, 2025 •

edited

Loading