fix: improve error handling and remove system data from error message idp managment #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanGerada3
changed the title
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+86
to
+92
| catch (Exception ex) | ||
| { | ||
| throw new ServiceException( | ||
| $"Failed to import identityprovider metadata: {ex.Message}", | ||
| HttpStatusCode.BadRequest | ||
| ); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
tfjanjua
reviewed
Nov 28, 2025
Contributor
tfjanjua
left a comment
tfjanjua
left a comment
There was a problem hiding this comment.
Change looks fine to me, just some extra spaces can be removed and line#96 https://github.com/eclipse-tractusx/portal-backend/pull/1474/files#diff-ffb6f719e2b7f835437d9fbfe055bf0265fb78d2d226d1d49c3276bc683c4c01R96 can be formatted.
CodeQL note is more important! please have a look on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved error handling and less revealing error response messages.
Why
The application consistently returns overly verbose error responses that expose internal implementation details whenever an external request or backend process fails. These responses include internal namespaces, library identifiers, upstream service URLs, and backend component references that should not be visible to end users.
Such information disclosure reveals aspects of the application’s architecture, technologies, and integration points, which could help an attacker map the internal environment and craft more targeted reconnaissance or exploitation attempts.
Issue
#1473
Checklist