feat: add BYOW step in flow#407
feat: add BYOW step in flow#407saloniGargFEDev wants to merge 14 commits intoeclipse-tractusx:mainfrom
Conversation
|
@saloniGargFEDev : I have tried to skip the wallet step but it still calls validateDID |
|
@saloniGargFEDev Also please look into the Sonar issues |
@dhiren-singh-007 Sonar issues have been fixed except one which conflicts with rules of pretty. |
typecastcloud
left a comment
There was a problem hiding this comment.
Some small formatting issues.
src/state/features/applicationWallet/applicationWalletApiSlice.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
|
@saloniGargFEDev once you enter wrong DID, there is an error, upon clicking again with wrong DID, there is no error. pls look into this. |
|
yes, token is still valid, but when you put the wrong ID, and click twice, only once the error message is triggered, the button does nothing on second click. |
and that's the correct flow. Because the button goes in loading state as soon as you click on the button and essentially the second click is not registered |
|
saadanzari
left a comment
There was a problem hiding this comment.
@saloniGargFEDev the latest changes has solved the problem, we can merge this now.
|
Dear @saloniGargFEDev, @lgblaumeiser thank you, |
Hi @axelalbrechtatsap, this can be merged but needs an approval from an Upstream Commiter. We would also need to merge eclipse-tractusx/portal#555 to enable the whole feature to work properly. |
|
@lgblaumeiser any chance for you to take a look here, please? |




Description
Added Wallet step as 5th step in registration flow
Changelog:
Why
The decentralization of the wallet and different offerings, such as self-hosted wallets (aka Bring your own Wallet, BYOW), it is required to implement different flows for the onboarding process. It will be necessary to make the necessary changes in the portal backend and frontend components. During the onboarding process the onboarding company will be given an option to use a white-label wallet as a service, offered by the Core Service Provider, or provide the DID of the wallet which they host in their infrastructure.
Issue
#1160
Checklist
Please delete options that are not relevant.