Skip to content

feat: add BYOW step in flow#407

Open
saloniGargFEDev wants to merge 14 commits intoeclipse-tractusx:mainfrom
Cofinity-X:feat/implement-BYOW-step
Open

feat: add BYOW step in flow#407
saloniGargFEDev wants to merge 14 commits intoeclipse-tractusx:mainfrom
Cofinity-X:feat/implement-BYOW-step

Conversation

@saloniGargFEDev
Copy link

@saloniGargFEDev saloniGargFEDev commented Jul 23, 2025

Description

Added Wallet step as 5th step in registration flow
Changelog:

  - **BYOW**
    - Added BYOW as the fifth step in registration flow.

Why

The decentralization of the wallet and different offerings, such as self-hosted wallets (aka Bring your own Wallet, BYOW), it is required to implement different flows for the onboarding process. It will be necessary to make the necessary changes in the portal backend and frontend components. During the onboarding process the onboarding company will be given an option to use a white-label wallet as a service, offered by the Core Service Provider, or provide the DID of the wallet which they host in their infrastructure.

Issue

#1160

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have commented my code, particularly in hard-to-understand areas

@hkny hkny requested review from Phil91 and dhiren-singh-007 July 25, 2025 09:03
@dhiren-singh-007
Copy link
Member

@saloniGargFEDev : I have tried to skip the wallet step but it still calls validateDID
image
Can you please check?

@dhiren-singh-007
Copy link
Member

@saloniGargFEDev Also please look into the Sonar issues

@saloniGargFEDev
Copy link
Author

saloniGargFEDev commented Jul 28, 2025

@saloniGargFEDev Also please look into the Sonar issues

@dhiren-singh-007 Sonar issues have been fixed except one which conflicts with rules of pretty.

Copy link
Contributor

@typecastcloud typecastcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small formatting issues.

saloniGargFEDev and others added 3 commits July 30, 2025 09:46
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
Co-authored-by: Karsten Thiems <karsten.thiems@cofinity-x.com>
@saadanzari
Copy link
Member

saadanzari commented Jul 30, 2025

@saloniGargFEDev once you enter wrong DID, there is an error, upon clicking again with wrong DID, there is no error. pls look into this.

Uploading Screenshot 2025-07-30 at 6.57.10 PM.png…

@saloniGargFEDev
Copy link
Author

@saloniGargFEDev once you enter wrong DID, there is an error, upon clicking again with wrong DID, there is no error. pls look into this.
@saadanzari Was your token still alive when you made the request again ? Please try again by putting in the wrong DID back to back without keeping it idle.

@saadanzari
Copy link
Member

@saloniGargFEDev once you enter wrong DID, there is an error, upon clicking again with wrong DID, there is no error. pls look into this.
@saadanzari Was your token still alive when you made the request again ? Please try again by putting in the wrong DID back to back without keeping it idle.

yes, token is still valid, but when you put the wrong ID, and click twice, only once the error message is triggered, the button does nothing on second click.

@saloniGargFEDev
Copy link
Author

@saloniGargFEDev once you enter wrong DID, there is an error, upon clicking again with wrong DID, there is no error. pls look into this.
@saadanzari Was your token still alive when you made the request again ? Please try again by putting in the wrong DID back to back without keeping it idle.

yes, token is still valid, but when you put the wrong ID, and click twice, only once the error message is triggered, the button does nothing on second click.

and that's the correct flow. Because the button goes in loading state as soon as you click on the button and essentially the second click is not registered

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2025

Copy link
Member

@saadanzari saadanzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saloniGargFEDev the latest changes has solved the problem, we can merge this now.

@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Aug 1, 2025
@typecastcloud typecastcloud added enhancement New feature or request merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled labels Aug 4, 2025
@axelalbrechtatsap
Copy link

Dear @saloniGargFEDev, @lgblaumeiser
As the backend implementation (eclipse-tractusx/portal-backend#1422) has been merged already, is there a chance to merge these front-end changes?
We were talking to @marcelruland from Cofinity-X and those two PRs are required to support the BYOW on the Catena-X INT landscape.
We would like to test the feature.

thank you,
Axel

@saloniGargFEDev
Copy link
Author

Dear @saloniGargFEDev, @lgblaumeiser As the backend implementation (eclipse-tractusx/portal-backend#1422) has been merged already, is there a chance to merge these front-end changes? We were talking to @marcelruland from Cofinity-X and those two PRs are required to support the BYOW on the Catena-X INT landscape. We would like to test the feature.

thank you, Axel

Hi @axelalbrechtatsap, this can be merged but needs an approval from an Upstream Commiter. We would also need to merge eclipse-tractusx/portal#555 to enable the whole feature to work properly.

@axelalbrechtatsap
Copy link

@lgblaumeiser any chance for you to take a look here, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled

Projects

Status: USER READY

Development

Successfully merging this pull request may close these issues.

6 participants