ftr: improvements after review

TRACEFOSS-891

Author: fbedarf

cypress.config.ts

@@ -27,7 +27,7 @@ export default defineConfig({
     specPattern: '**/*.feature',
     supportFile: false,
     viewportWidth: 1366,
-    viewportHeight: 768,
+    viewportHeight: 900,
     experimentalWebKitSupport: true, // https://docs.cypress.io/guides/guides/launching-browsers#WebKit-Experimental
     setupNodeEvents,
   },

src/app/modules/core/kown-route.ts src/app/modules/core/known-route.tssrc/app/modules/core/kown-route.ts renamed to src/app/modules/core/known-route.ts

@@ -21,7 +21,7 @@
 
 import { Component } from '@angular/core';
 import { NavigationEnd, Router } from '@angular/router';
-import { KnownUrl, NavigableUrls } from '@core/kown-route';
+import { KnownUrl, NavigableUrls } from '@core/known-route';
 import { filter } from 'rxjs/operators';
 
 @Component({

src/app/modules/core/layout/header/header.component.ts

@@ -29,7 +29,7 @@ import {
   NO_PERMISSION_BASE_ROUTE,
   OTHER_PARTS_BASE_ROUTE,
   PARTS_BASE_ROUTE,
-} from '@core/kown-route';
+} from '@core/known-route';
 import { RoleGuard } from '@core/user/role.guard';
 import { ErrorPageType } from '@page/error-page/model/error-page.model';
 

src/app/modules/core/layout/layout.routing.ts

@@ -21,7 +21,7 @@
 
 import { Component, OnDestroy, OnInit, ViewChild } from '@angular/core';
 import { Router } from '@angular/router';
-import { getRoute } from '@core/kown-route';
+import { getRoute, INVESTIGATION_BASE_ROUTE } from '@core/known-route';
 import { InvestigationsFacade } from '@page/investigations/core/investigations.facade';
 import { Notification, Notifications, NotificationStatusGroup } from '@shared/model/notification.model';
 import { View } from '@shared/model/view.model';
@@ -59,7 +59,7 @@ export class DashboardComponent implements OnInit, OnDestroy {
     this.assetsPerCountry$ = this.dashboardFacade.assetsPerCountry$;
     this.investigations$ = this.dashboardFacade.investigations$;
 
-    const { link, queryParams } = getRoute('investigations', NotificationStatusGroup.RECEIVED);
+    const { link, queryParams } = getRoute(INVESTIGATION_BASE_ROUTE, NotificationStatusGroup.RECEIVED);
     this.investigationLink = link;
     this.investigationParams = queryParams;
   }
@@ -73,7 +73,7 @@ export class DashboardComponent implements OnInit, OnDestroy {
   }
 
   public onNotificationSelected(notification: Notification): void {
-    const { link } = getRoute('investigations');
+    const { link } = getRoute(INVESTIGATION_BASE_ROUTE);
     this.router.navigate([`/${link}/${notification.id}`]).then();
   }
 }

src/app/modules/page/dashboard/presentation/dashboard.component.ts

@@ -21,7 +21,7 @@
 
 import { AfterContentInit, Component, OnDestroy, OnInit, ViewChild } from '@angular/core';
 import { Router } from '@angular/router';
-import { getRoute } from '@core/kown-route';
+import { getRoute, INVESTIGATION_BASE_ROUTE } from '@core/known-route';
 import { InvestigationDetailFacade } from '@page/investigations/core/investigation-detail.facade';
 import { InvestigationHelperService } from '@page/investigations/core/investigation-helper.service';
 import { MenuActionConfig, TablePaginationEventConfig } from '@shared/components/table/table.model';
@@ -122,7 +122,7 @@ export class InvestigationsComponent implements OnInit, OnDestroy, AfterContentI
 
   public openDetailPage(notification: Notification): void {
     this.investigationDetailFacade.selected = { data: notification };
-    const { link } = getRoute('investigations');
+    const { link } = getRoute(INVESTIGATION_BASE_ROUTE);
     this.router.navigate([`/${link}/${notification.id}`]).then();
   }
 

src/app/modules/page/investigations/presentation/investigations.component.ts

@@ -21,7 +21,7 @@
 
 import { Component, EventEmitter, Input, Output } from '@angular/core';
 import { UntypedFormControl, UntypedFormGroup, Validators } from '@angular/forms';
-import { getRoute } from '@core/kown-route';
+import { getRoute, INVESTIGATION_BASE_ROUTE } from '@core/known-route';
 import { OtherPartsFacade } from '@page/other-parts/core/other-parts.facade';
 import { Part } from '@page/parts/model/parts.model';
 import { CtaSnackbarService } from '@shared/components/call-to-action-snackbar/cta-snackbar.service';
@@ -88,7 +88,7 @@ export class RequestInvestigationComponent {
   }
 
   private openCtaSnackbar(count: number): void {
-    const { link, queryParams } = getRoute('investigations', NotificationStatusGroup.QUEUED_AND_REQUESTED);
+    const { link, queryParams } = getRoute(INVESTIGATION_BASE_ROUTE, NotificationStatusGroup.QUEUED_AND_REQUESTED);
 
     this.ctaSnackbarService.show(
       {