feat: Decentral Connector Service Discovery based on DID Document Service Entries #2507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../src/main/java/org/eclipse/tractusx/edc/discovery/v4alpha/spi/ConnectorDiscoveryService.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
| */ | ||
| ServiceResult<JsonObject> discoverVersionParams(ConnectorParamsDiscoveryRequest request); | ||
|
|
||
| CompletableFuture<ServiceResult<JsonArray>> discoverConnectors(ConnectorDiscoveryRequest request); |
Check notice
Code scanning / CodeQL
Useless parameter Note
Copilot Autofix
AI about 3 hours ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
Signed-off-by: Lars Geyer-Blaumeiser <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
A new endpoint /v4alpha/connectordiscovery/connectors has been added. The endpoint runs a request on the DID document of the given provider did and retrieves the DataService service entries from that document. Based on this information, it does for every connector reference found the version detection and returns an array of connection parameters, one for each connetor.
WHY
To simplify the decentral discovery mechanism as proposed in the DSP protocol spec and being introduced in Catena-X with Saturn.
Closes #2461