Migrate from decentxml to domtrip library #5407
Draft
+527
−586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate the decentxml library to the new maveniverse/domtrip
Migrate from decentxml to domtrip library
Sep 30, 2025
laeubi
requested changes
Sep 30, 2025
Member
There was a problem hiding this comment.
There are some compile errors now please see the output of https://github.com/eclipse-tycho/tycho/actions/runs/18136058914/job/51616642835?pr=5407
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.14.1:compile (default-compile) on project tycho-core: Compilation failure: Compilation failure:
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[58,55] cannot find symbol
Error: symbol: method stream()
Error: location: interface java.util.stream.Stream<eu.maveniverse.domtrip.Element>
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[75,54] for-each not applicable to expression type
Error: required: array or java.lang.Iterable
Error: found: java.util.stream.Stream<eu.maveniverse.domtrip.Element>
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[95,21] cannot find symbol
Error: symbol: class XMLWriter
Error: location: class org.eclipse.tycho.core.EcJLogFileEnhancer
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[95,40] cannot find symbol
Error: symbol: class XMLWriter
Error: location: class org.eclipse.tycho.core.EcJLogFileEnhancer
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[102,9] cannot find symbol
Error: symbol: class XMLParser
Error: location: class org.eclipse.tycho.core.EcJLogFileEnhancer
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[102,32] cannot find symbol
Error: symbol: class XMLParser
Error: location: class org.eclipse.tycho.core.EcJLogFileEnhancer
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[105,22] cannot find symbol
Error: symbol: method name()
Error: location: variable child of type java.io.File
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[106,46] no suitable method found for of(java.io.File)
Error: method eu.maveniverse.domtrip.Document.of(java.lang.String) is not applicable
Error: (argument mismatch; java.io.File cannot be converted to java.lang.String)
Error: method eu.maveniverse.domtrip.Document.of(java.io.InputStream) is not applicable
Error: (argument mismatch; java.io.File cannot be converted to java.io.InputStream)
Error: method eu.maveniverse.domtrip.Document.of(java.nio.file.Path) is not applicable
Error: (argument mismatch; java.io.File cannot be converted to java.nio.file.Path)
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[113,33] cannot find symbol
Error: symbol: method getChild(java.lang.String)
Error: location: variable source of type eu.maveniverse.domtrip.Element
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[120,19] method addNode in class eu.maveniverse.domtrip.ContainerNode cannot be applied to given types;
Error: required: eu.maveniverse.domtrip.Node
Error: found: int,eu.maveniverse.domtrip.Element
Error: reason: actual and formal argument lists differ in length
Error: /home/runner/work/tycho/tycho/tycho-core/src/main/java/org/eclipse/tycho/core/EcJLogFileEnhancer.java:[184,48] cannot find symbol
Error: symbol: method stream()
Error: location: interface java.util.stream.Stream<eu.maveniverse.domtrip.Element>
Member
|
@copilot this currently fails compilation with |
…() calls The children() method in domtrip already returns a Stream<Element>, so calling .stream() on it was causing a compilation error. Removed the redundant .stream() calls on lines 58 and 59. Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Contributor
Author
... Fixed in commit fa2f5db. The issue was that domtrip's |
Member
|
@waynebeaton as discussed in the EAC meeting this is one of a bigger PR about 500 LOC, so lots of lines changed and will likely require my attention to be adjusted so how much should one attribute the AI and how much should the one adjusting the PR be attributed? Would there even be a limit, e.g. assume we hit the 1000 LOC would it require any special attention? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of decentxml to domtrip - COMPLETE:
Summary:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.