Skip to content

Conversation

@vietj
Copy link
Member

@vietj vietj commented May 25, 2023

A refactoring that decouples a few things + framing introduction

  • decouple the registration handlers from current interactions (e.g remove the reply handler knowledge from the registration handler)
  • a registration handler now process generic frames
  • a message is a frame
  • clustering are responsible to send frames to peers very much like they are sending messages (which is now a specific frame)

Thanks to frames we keep existing interactions as well as allow new interactions to support bidi streaming. Very similar to TCP we have syn/fin frames between peers to control stream boundaries.

See also #4712 that does the same but keep the existing protocol using codecs to implement the protocol instead of adding frames.

@vietj
Copy link
Member Author

vietj commented May 25, 2023

@tsegismont FYI

@vietj vietj force-pushed the event-bus-streaming-mockup branch from ddaebb0 to 761f252 Compare May 25, 2023 07:35
@vietj vietj added this to the 5.0.0 milestone May 26, 2023

Buffer encodeToWire();

boolean isFromWire();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an Enum FrameSource?

@vietj vietj modified the milestones: 5.0.0, 5.1.0 May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants