ReadStream can be adapted to a Java blocking stream #5526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The Vert.x virtual stream programming model provides async/await to interact with asynchronous futures, yet the stream approach has been left naked. Changes: A new ReadStream blockingStream default method is added to convert a ReadStream to a java.util.stream.Stream. This blocking stream can be used from a Vert.x virtual thread or a non Vert.x thread. When used from a Vert.x virtual thread, each blocking interaction with the stream suspends the virtual thread and release the context ownership to let other tasks process tasks, allowing the context execution to happen and handle pending context tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The Vert.x virtual stream programming model provides async/await to interact with asynchronous futures, yet the stream approach has been left naked.
Changes:
A new
ReadStreamblockingStream default method is added to convert aReadStreamto ajava.util.stream.Stream.This blocking stream can be used from a Vert.x virtual thread or a non Vert.x thread.
When used from a Vert.x virtual thread, each blocking interaction with the stream suspends the virtual thread and release the context ownership to let other tasks process tasks, allowing the context execution to happen and handle pending context tasks.