Propagate correctly the HTTP connection metric to the WebSocket connection metric during the server upgrade #5581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction metric during the server upgrade. Motivation: During a server WebSocket upgrade, the HTTP connection metric is not correctly set to the WebSocket connection metric. This leads to calling the metric implementation with a null instance of the metric instead of the the instance it was provided. Changes: During the server WebSocket upgrade set the HTTP connection metric onto the WebSocket connection metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
During a server WebSocket upgrade, the HTTP connection metric is not correctly set to the WebSocket connection metric.
This leads to calling the metric implementation with a null instance of the metric instead of the the instance it was provided.
Changes:
During the server WebSocket upgrade set the HTTP connection metric onto the WebSocket connection metric.