Let the DeliveryContext next implementation work correctly when used by different threads #5739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by different threads. Motivation: The current implementation of DeliveryContext#next assumes the same thread makes interceptor delivery progress, this API however assumes any thread can make interceptor progress. Changes: Rewrite the implementation of DeliveryContext#next with an atomic interceptor index that guarantees that progress is visible accross threads until the last interceptor is invoked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The current implementation of
DeliveryContext#nextassumes the same thread makes interceptor delivery progress, this API however assumes any thread can make interceptor progress.Changes:
Rewrite the implementation of
DeliveryContext#nextwith an atomic interceptor index that guarantees that progress is visible across threads until the last interceptor is invoked.