Extend HTTP client metrics lifecyle #5835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by the HTTP client before the request is actually sent. Motivation: The ClientMetrics SPI design creates a request metric when the request headers are written, we should actually relax this constraint and let client obtain a metric from the SPI before headers are written, in order to give the oppportunity to customize the request metric object before headers are written. Changes: Extend ClientMetrics SPI to add a new init method that produces a metrics instance. When the implementation returns null, the client behaves with a compatibility mode and calls ClientMetrics#requestBegin to signal the beginning of the request and obtain the request metric. When the implementation returns non-null, the client instead calls the ClientMetrics#requestBegin overload that accepts the request metric instance that should be handed back to the SPI.
Member
Author
|
@geoand this is the backport to 4.x |
Contributor
|
Thanks a lot! I'll test it on Monday |
…quest metric. Motivation: Sometimes it is necessary to let framework access to underlying metric of an HTTP request in order to reliably and efficiently share state with the metrics implementation. This is useful for frameworks that build on top of HTTP client and wants to extend metrics reporting beyond Vert.x capabitilies.
vietj
force-pushed
the
client-metrics-lifecycle-4.x
branch
from
c4b70eb to
acb53cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
ClientMetricsSPI should give the opportunity to frameworks building on top of Vert.x HTTP client to customize the request metric before headers are written.Changes:
ClientMetricswith new methods that decouple request metric create (init) and request headers write signal (requestBegin)HttpClientRequestInternalextension that exposes the request metric instance