Skip to content

Conversation

@ahus1
Copy link
Contributor

@ahus1 ahus1 commented Dec 25, 2025

Closes #5857

Motivation:

Ensure setup is only called once. Otherwise there are multiple methods annotated with @Before.

@ahus1 ahus1 changed the title Ensure setup is only called once Ensure setup is only called once in VirtualThreadEventBusTest, VirtualThreadContextTest and NetBandwidthLimitingTest Dec 25, 2025
@ahus1 ahus1 marked this pull request as ready for review December 25, 2025 10:29
@ahus1
Copy link
Contributor Author

ahus1 commented Dec 25, 2025

@vietj - This applies the same pattern to avoid calling setUp() twice as in #5852. Please review when you have the time. Thanks!

@vietj vietj modified the milestones: 5.0.7, 5.1.0 Dec 26, 2025
@vietj vietj merged commit 57b9c68 into eclipse-vertx:master Dec 26, 2025
7 checks passed
@ahus1 ahus1 deleted the is-5857-avoid-calling-setup-twice branch December 30, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid calling setup multiple times in several test classes

2 participants