Ensure setup is only called once in VirtualThreadEventBusTest, VirtualThreadContextTest and NetBandwidthLimitingTest [4.x]#5859
Merged
vietj merged 1 commit intoeclipse-vertx:4.xfrom Dec 30, 2025
Conversation
Closes eclipse-vertx#5857 (cherry picked from commit 57b9c68)
ahus1
changed the title
Contributor
Author
|
@vietj - this is a backport of my changes to the There is a failing test and I opened the following issue to track it. I already found the cause and proposed a fix, still I might need more discussion. I hope this PR can still be merged as the CI failure is unrelated to this PR. Please review when you have the time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5857
(cherry picked from commit 57b9c68)
Motivation:
Setup should not be called twice due to the
@Beforeanotation