Skip to content

Stabilize test by keeping reference to NetClient [4.x] #5861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vietj merged 1 commit into from
Dec 29, 2025
Merged

Stabilize test by keeping reference to NetClient [4.x] #5861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/test/java/io/vertx/core/http/HttpTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

package io.vertx.core.http;

import io.netty.buffer.ByteBufUtil;
import io.netty.channel.ConnectTimeoutException;
import io.netty.handler.codec.compression.DecompressionException;
import io.netty.handler.codec.http.HttpHeaderNames;
Expand Down Expand Up @@ -5179,14 +5180,17 @@ protected void testHttpConnect(RequestOptions options, int sc) {
Buffer buffer = TestUtils.randomBuffer(128);
Buffer received = Buffer.buffer();
CompletableFuture<Void> closeSocket = new CompletableFuture<>();
vertx.createNetServer(new NetServerOptions().setPort(1235).setHost("localhost")).connectHandler(socket -> {
// Declare netClient in the main thread to avoid having it randomly garbage collected just after it created the connection
NetClient netClient = vertx.createNetClient(new NetClientOptions());

vertx.createNetServer(new NetServerOptions().setPort(0).setHost("localhost")).connectHandler(socket -> {
socket.handler(socket::write);
closeSocket.thenAccept(v -> {
socket.close();
});
}).listen(onSuccess(netServer -> {
server.requestHandler(req -> {
vertx.createNetClient(new NetClientOptions()).connect(1235, "localhost", onSuccess(dst -> {
netClient.connect(netServer.actualPort(), "localhost", onSuccess(dst -> {

req.response().setStatusCode(sc);
req.response().setStatusMessage("Connection established");
Expand Down Expand Up @@ -5217,7 +5221,7 @@ protected void testHttpConnect(RequestOptions options, int sc) {
}
});
socket.closeHandler(v -> {
assertEquals(buffer, received);
assertEquals(ByteBufUtil.hexDump(buffer.getBytes()), ByteBufUtil.hexDump(received.getBytes()));
testComplete();
});
socket.write(buffer);
Expand Down
Loading