Stabilize test HttpBandwidthLimitingTest.testDynamicOutboundRateUpdateSharedServers [4.x]#5864
Merged
vietj merged 1 commit intoeclipse-vertx:4.xfrom Dec 30, 2025
Conversation
…eSharedServers Only a server that has completed the listening is ready to update the traffic shaping. Closes eclipse-vertx#5863
ahus1
force-pushed
the
is-5863-stabilize-testDynamicOutboundRateUpdateSharedServers-4.x
branch
from
680c98c to
de73a91
Compare
ahus1
changed the title
vietj
reviewed
Dec 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only a server that has completed the listening is ready to update the traffic shaping.
Closes #5863
Motivation:
This both fixes the test that now only acts on fully initialized server instances, as well as adds additional safety measures on
TCPServerBase.java.As 4.x is AFAIK in maintenance mode, I'm happy to discuss if those changes to
TCPServerBaseshould change some behavior people might depend on. Looking at theTCPServerBase.listen()code, it was a bit surprising to me that a failing bind-future on the actual server will reset the listening flag ...vert.x/src/main/java/io/vertx/core/net/impl/TCPServerBase.java
Lines 280 to 287 in 8e06aa8
... while it will not do the same on the other servers ....
vert.x/src/main/java/io/vertx/core/net/impl/TCPServerBase.java
Line 300 in 8e06aa8
Happy to discuss how to shape this PR, and what should be handled in follow-up issues.