Replace apacheds-protocol-dns with mock Netty dns server in tests Reopened#5871
Replace apacheds-protocol-dns with mock Netty dns server in tests Reopened#5871pendula95 wants to merge 6 commits intoeclipse-vertx:masterfrom
Conversation
|
@vietj all the tests on local run are passing, this is ready for review |
|
@pendula95 can you make a rebase of this PR on latest master please ? |
|
@pendula95 can you also look at other projects in the vertx stack that are using this project (e.g. I think vertx-service-resolver uses it) and check that those projects can use the new mock dns server ? |
I have checked both eclipse-vertx and vert-x3 organizations for code references of apacheds-protocol-dns an I only found reference in vertx-service-resolver and https://github.com/vert-x3/vertx-stack vertx-service-resolver has been addressed and PR submitted eclipse-vertx/vertx-service-resolver#31 For vertx-stack I guess the property also could be removed. Resolves #5819 |
|
@pendula95 great work, can you provide a single commit for this PR based on the latest master ? |
2044ec2 to
b69d714
Compare
I am unable to elegantly squash it using |
|
@pendula95 I think you can create a new branch from latest master and cherry pick commits of your branch on top of it |
# Conflicts: # vertx-core/src/test/java/io/vertx/tests/http/HttpTest.java
|
|
Resolved by #5900 |
No description provided.