create metrics with actual server port#6019
Merged
vietj merged 3 commits intoeclipse-vertx:5.0from Mar 26, 2026
Merged
Conversation
vietj
reviewed
Mar 16, 2026
vertx-core/src/test/java/io/vertx/test/fakemetrics/FakeHttpServerMetrics.java
Outdated
Show resolved
Hide resolved
vietj
force-pushed
the
fix/metricsactualport
branch
from
9c59c0d to
f95c782
Compare
Member
|
@hcura can you port this to master branch ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that metrics are created with the actual server port (for test cases where port is dynamic).