Merged
Conversation
vietj
force-pushed
the
remove-http-server-config-ssl-boolean
branch
from
444bfa4 to
bc26b27
Compare
Motivation: HttpServerConfig has copied the boolean ssl flag from HttpServerOptions. Since on HTTP server there is no start TLS behavior, we can remove this configuration and state that ssl <=> ssl options != null Changes: Remove HttpServerConfig#ssl boolean and update tests / examples accordingly.
vietj
force-pushed
the
remove-http-server-config-ssl-boolean
branch
from
bc26b27 to
5d4c2b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
HttpServerConfig has copied the boolean ssl flag from HttpServerOptions.
Since on HTTP server there is no start TLS behavior, we can remove this configuration and state that ssl <=> ssl options != null
Changes:
Remove HttpServerConfig#ssl boolean and update tests / examples accordingly.