Unified head interception #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
reviewed
Nov 8, 2024
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorImpl.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorImpl.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorImpl.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/HeadInterceptorBuilder.java
Outdated
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorBuilderImpl.java
Show resolved
Hide resolved
tsegismont
reviewed
Nov 8, 2024
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thanks @vietj , great PR
A couple of comments/concerns
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorImpl.java
Show resolved
Hide resolved
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorBuilderImpl.java
Outdated
Show resolved
Hide resolved
Motivation: The new interceptors for changing request/response head each do a separate change yet they only modify the request/response head. We should instead have a single interceptor that can implement all of them a batch the modification of the head in a single interceptor. The builder pattern can be used to build such interceptor with the desired modification of the developer Changes: A new HeadInterceptor with a builder that aggregates the existing head individual interceptors.
The builder configuration methods can be invoked several times. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
head-interceptor
branch
from
5331040 to
dcff06b
Compare
Member
|
@vietj I've updated PR, can you please take a look? Thank you |
vietj
commented
Nov 15, 2024
src/main/java/io/vertx/httpproxy/interceptors/impl/HeadInterceptorBuilderImpl.java
Show resolved
Hide resolved
vietj
commented
Nov 15, 2024
- Can be invoked several times - Operations are invoked in the order of configuration Signed-off-by: Thomas Segismont <[email protected]>
Member
|
@vietj PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The new interceptors for changing request/response head each do a separate change yet they only modify the request/response head.
We should instead have a single interceptor that can implement all of them a batch the modification of the head in a single interceptor.
The builder pattern can be used to build such interceptor with the desired modification of the developer
Changes:
A new HeadInterceptor with a builder that aggregates the existing head individual interceptors.