Skip to content

Conversation

@yeikel
Copy link

@yeikel yeikel commented Jan 20, 2026

Fixes the following warning:

org.junit.jupiter.engine.descriptor.AbstractExtensionContext msg=Type implements CloseableResource but not AutoCloseable: io.vertx.junit5.ScopedObject   

Motivation:

Explain here the context, and why you're making that change, what is the problem you're trying to solve.

#145 (comment)

@yeikel yeikel mentioned this pull request Jan 20, 2026
@tsegismont
Copy link
Member

@yeikel yeikel force-pushed the patch-3 branch 2 times, most recently from a1d15c9 to c6bebde Compare January 20, 2026 18:17
@yeikel
Copy link
Author

yeikel commented Jan 20, 2026

There's a compilation issue: https://github.com/eclipse-vertx/vertx-junit5/actions/runs/21181289763/job/60925744517?pr=149#step:4:11

Apologies, it should be fixed now

@tsegismont tsegismont modified the milestone: 4.5.25 Jan 21, 2026
@tsegismont
Copy link
Member

There was an issue at runtime. Closing, superseded by #152

@tsegismont tsegismont closed this Jan 21, 2026
@yeikel
Copy link
Author

yeikel commented Jan 21, 2026

There was an issue at runtime. Closing, superseded by #152

What was the issue?

@yeikel yeikel deleted the patch-3 branch January 21, 2026 12:18
@tsegismont
Copy link
Member

The extension was not properly recognized at runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants