Skip to content

Conversation

@vietj
Copy link
Member

@vietj vietj commented Feb 22, 2024

No description provided.

@pendula95
Copy link
Contributor

I am not able to evaluate but now this changes the behavior of

public void cancelRequest(PgConnectOptions options, int processId, int secretKey, Handler<AsyncResult<Void>> handler) {
doConnect(options.getSocketAddress(), vertx.createEventLoopContext(), options).onComplete(ar -> {
if (ar.succeeded()) {
PgSocketConnection conn = (PgSocketConnection) ar.result();
conn.sendCancelRequestMessage(processId, secretKey, handler);
} else {
handler.handle(Future.failedFuture(ar.cause()));
}
});
}

Previously canceled requests did not send Startup. For this I suggest pass a flag cancelRequest

@vietj
Copy link
Member Author

vietj commented Mar 6, 2024

@pendula95 a couple of concerns raised

@pendula95
Copy link
Contributor

You are quite right, I have corrected everything here: #1421

Sorry for creating additional PRs but as I dont have permissions to directly commit here I dont see any other way

@vietj
Copy link
Member Author

vietj commented Mar 6, 2024

@pendula95 don't be sorry, that's how it is supposed to be done

@pendula95
Copy link
Contributor

#1422

@vietj vietj marked this pull request as ready for review March 7, 2024 08:47
@vietj vietj added this to the 5.0.0 milestone Mar 7, 2024
@vietj vietj changed the title Pendula95 fix recover for ssl mode always Incorrect handling of SSL mode always for PostgreSQL Mar 7, 2024
@vietj vietj changed the title Incorrect handling of SSL mode always for PostgreSQL Correct handling of SSL mode always for PostgreSQL Mar 7, 2024
@vietj vietj merged commit 5ab12ad into master Mar 7, 2024
@vietj vietj deleted the pendula95-fix-recover-for-ssl-mode-always branch March 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants