JPMS support #1445
Merged
JPMS support #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of the client (e.g. vertx-jdbc-client).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring JPMS support to SQL client.
Due to the incapacity of test containers to run with JPMS (testcontainers/testcontainers-java#7337) tests have not been touched and tests are executed with a class-path instead of a module-path.
The part of the API that is used in vertx-jdbc-client (the bridge between the API and the back-end system) has been extracted outside of the
io.vertx.sqlclient.implso vertx-jdbc-client can also become a JPMS module. This part will most likely be extracted in a new module to better encapsulate it and avoid it in the user-facing API.