Skip to content

Disable OracleConnectionTest#testConnectNoLeak tests #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Disable OracleConnectionTest#testConnectNoLeak tests #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions vertx-oracle-client/src/test/java/io/vertx/oracleclient/test/tck/OracleConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import io.vertx.sqlclient.spi.DatabaseMetadata;
import io.vertx.sqlclient.tck.ConnectionTestBase;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;

@RunWith(VertxUnitRunner.class)
Expand All @@ -41,4 +43,24 @@ protected void validateDatabaseMetaData(TestContext ctx, DatabaseMetadata md) {
ctx.assertTrue(md.fullVersion().contains("Oracle"));
ctx.assertTrue(md.productName().contains("Oracle"));
}

@Test
@Ignore
@Override
public void testConnectNoLeak(TestContext ctx) throws Exception {
// Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database
// https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai
// Probable cause is that the service handler gets in a blocked state and is not accepting new connections
super.testConnectNoLeak(ctx);
}

@Test
@Ignore
@Override
public void testConnectNoLeakInVerticle(TestContext ctx) throws Exception {
// Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database
// https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai
// Probable cause is that the service handler gets in a blocked state and is not accepting new connections
super.testConnectNoLeakInVerticle(ctx);
}
}
Loading