Skip to content

Re enable no leak oracle tests #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Re enable no leak oracle tests #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0178c4
Revert "Disable OracleConnectionTest#testConnectNoLeak tests (#1482)"
tsegismont Jan 8, 2025
6fa3ed3
Reduce number of connections made in testConnectNoLeak tests
tsegismont Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions vertx-oracle-client/src/test/java/io/vertx/oracleclient/test/tck/OracleConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
import io.vertx.sqlclient.spi.DatabaseMetadata;
import io.vertx.sqlclient.tck.ConnectionTestBase;
import org.junit.ClassRule;
import org.junit.Ignore;
import org.junit.Test;
import org.junit.runner.RunWith;

@RunWith(VertxUnitRunner.class)
Expand All @@ -43,24 +41,4 @@ protected void validateDatabaseMetaData(TestContext ctx, DatabaseMetadata md) {
ctx.assertTrue(md.fullVersion().contains("Oracle"));
ctx.assertTrue(md.productName().contains("Oracle"));
}

@Test
@Ignore
@Override
public void testConnectNoLeak(TestContext ctx) throws Exception {
// Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database
// https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai
// Probable cause is that the service handler gets in a blocked state and is not accepting new connections
super.testConnectNoLeak(ctx);
}

@Test
@Ignore
@Override
public void testConnectNoLeakInVerticle(TestContext ctx) throws Exception {
// Disabled for Oracle because we frequently get ORA-12516 Cannot connect to database
// https://docs.oracle.com/en/error-help/db/ora-12516/?r=23ai
// Probable cause is that the service handler gets in a blocked state and is not accepting new connections
super.testConnectNoLeakInVerticle(ctx);
}
}
8 changes: 4 additions & 4 deletions vertx-sql-client/src/test/java/io/vertx/sqlclient/tck/ConnectionTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ public void testConnect(TestContext ctx) {
public void testConnectNoLeak(TestContext ctx) throws Exception {
Set<SqlConnectionBase<?>> connections = Collections.synchronizedSet(Collections.newSetFromMap(new WeakHashMap<>()));
Set<ConnectionFactory> factories = Collections.synchronizedSet(Collections.newSetFromMap(new WeakHashMap<>()));
Async async = ctx.async(100);
for (int i = 0; i < 100; i++) {
Async async = ctx.async(10);
for (int i = 0; i < 10; i++) {
connect(ctx.asyncAssertSuccess(conn -> {
SqlConnectionBase<?> base = (SqlConnectionBase<?>) conn;
connections.add(base);
Expand All @@ -80,11 +80,11 @@ public void testConnectNoLeak(TestContext ctx) throws Exception {
public void testConnectNoLeakInVerticle(TestContext ctx) throws Exception {
Set<SqlConnectionBase<?>> connections = Collections.synchronizedSet(Collections.newSetFromMap(new WeakHashMap<>()));
Set<ConnectionFactory> factories = Collections.synchronizedSet(Collections.newSetFromMap(new WeakHashMap<>()));
Async async = ctx.async(100);
Async async = ctx.async(10);
vertx.deployVerticle(new AbstractVerticle() {
@Override
public void start() throws Exception {
for (int i = 0; i < 100; i++) {
for (int i = 0; i < 10; i++) {
connect(ctx.asyncAssertSuccess(conn -> {
SqlConnectionBase<?> base = (SqlConnectionBase<?>) conn;
connections.add(base);
Expand Down
Loading