Skip to content

Fix ClassCastException when reading a null arrays of enums #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

Fix ClassCastException when reading a null arrays of enums #1505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions vertx-pg-client/src/main/java/io/vertx/pgclient/impl/RowImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,12 @@ private Interval[] getArrayOfIntervals(int pos) {
return (Interval[]) getValue(pos);
}

@SuppressWarnings({"unchecked", "rawtypes"})
private Object[] getArrayOfEnums(Class enumType, int pos) {
Object val = getValue(pos);
if (val == null) {
return null;
}
if (val instanceof String[]) {
String[] array = (String[]) val;
Object[] ret = (Object[]) Array.newInstance(enumType, array.length);
Expand All @@ -276,7 +280,8 @@ private Object[] getArrayOfEnums(Class enumType, int pos) {
}
}
return ret;
} else if (val instanceof Number[]) {
}
if (val instanceof Number[]) {
Number[] array = (Number[]) val;
Object[] ret = (Object[]) Array.newInstance(enumType, array.length);
Object[] constants = enumType.getEnumConstants();
Expand All @@ -290,8 +295,7 @@ private Object[] getArrayOfEnums(Class enumType, int pos) {
}
}
return ret;
} else {
throw new ClassCastException();
}
throw new ClassCastException();
}
}
16 changes: 16 additions & 0 deletions vertx-pg-client/src/test/java/io/vertx/tests/pgclient/data/JavaEnumTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,22 @@ private void testJavaEnumToArrayColumn(TestContext ctx, String value, String sql
}));
}

@Test
public void testJavaEnumToNullArrayColumn(TestContext ctx) {
PgConnection.connect(vertx, options).onComplete(ctx.asyncAssertSuccess(conn -> {
conn
.preparedQuery("SELECT NULL")
.execute()
.onComplete(ctx.asyncAssertSuccess(v -> {
RowIterator<Row> it = v.iterator();
ctx.assertTrue(it.hasNext());
Row row = it.next();
Mood[] result = row.get(Mood[].class, 0);
ctx.assertNull(result);
}));
}));
}

@Test
public void testJavaEnumToEnumParam(TestContext ctx) {
testJavaEnumToParam(ctx, "happy", "Mood");
Expand Down