Skip to content

Improve eager command failure in PostgreSQL client #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Improve eager command failure in PostgreSQL client #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions vertx-pg-client/src/main/java/io/vertx/pgclient/impl/codec/PgCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import io.netty.channel.ChannelHandlerContext;
import io.netty.channel.CombinedChannelDuplexHandler;
import io.vertx.core.Completable;
import io.vertx.sqlclient.ClosedConnectionException;
import io.vertx.sqlclient.internal.command.CommandBase;
import io.vertx.sqlclient.internal.command.CommandResponse;
Expand Down Expand Up @@ -82,9 +83,10 @@ private void fail(Throwable cause) {
}

private void fail(PgCommandCodec<?, ?> codec, Throwable cause) {
CommandResponse<Object> failure = CommandResponse.failure(cause);
failure.cmd = (CommandBase) codec.cmd;
chctx.fireChannelRead(failure);
Completable<?> handler = codec.cmd.handler;
if (handler != null) {
handler.complete(null, cause);
}
}

@Override
Expand Down
1 change: 0 additions & 1 deletion vertx-pg-client/src/test/java/io/vertx/tests/pgclient/CloseConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ private void testCloseConnection(TestContext ctx, Runnable test) {
}

@Test
@Ignore("Ignored due to https://github.com/eclipse-vertx/vertx-sql-client/issues/1506")
public void testTransactionInProgressShouldFail(TestContext ctx) {
ProxyServer proxy = ProxyServer.create(vertx, options.getPort(), options.getHost());
proxy.proxyHandler(conn -> {
Expand Down