Let the vertx-pg-client encoder estimate the capacity of buffer it allocates #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
force-pushed
the
pg-encoder-loop-rewrite
branch
2 times, most recently
from
555d5e9 to
f68ab45
Compare
…locates. Motivation: The pg encoder allocates Netty buffer without an initial capacity, when pipelining is used this buffer can be reallocated multiple times and in agressive scenario can lead to out of memory errors with the adapative allocator. Changes: Cumulate and encode all the outbound messages at once when flush happens instead of cumulating them in the outbound buffer. Capacity is estimated when a message is enqueued. At flush time, a single buffer of the estimated capacity is created and the outbound messages are written to this buffer. This requires to pre-render some messages to estimate their length, e.g. a json object is pre-rendered to a string that can be then estimated. The client has been modified to handle message preparation which takes care of this and lazy duplicate the tuple / list of tuples when this happens.
vietj
force-pushed
the
pg-encoder-loop-rewrite
branch
from
f68ab45 to
e4956f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The pg encoder allocates Netty buffer without an initial capacity, when pipelining is used this buffer can be reallocated multiple times and in agressive scenario can lead to out of memory errors with the adapative allocator.
Changes:
Cumulate and encode all the outbound messages at once when flush happens instead of cumulating them in the outbound buffer.
Capacity is estimated when a message is enqueued.
At flush time, a single buffer of the estimated capacity is created and the outbound messages are written to this buffer.
This requires to pre-render some messages to estimate their length, e.g. a json object is pre-rendered to a string that can be then estimated. The client has been modified to handle message preparation which takes care of this and lazy duplicate the tuple / list of tuples when this happens.