Command messages #1535
Merged
Command messages #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mandCodec for more clarity.
… MySQLCommandCodec for more clarity.
… MSSQLCommandCodec for more clarity.
…CommandCodec for more clarity.
…ge and the associated flow. Motivation: Currently each codec takes care of failing the inflight command messages when a failure occurs in the pipeline. The socket connection already takes care of translating command responses to completion of the command handler. We should let the socket connection take care of handling the case of failure, this avoids propagating the command response handler to each codec and the codec only cares about writing an inbound command response message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandMessageare namedXXXCodecdue to the original design.We should name those classes
XXXCommandMessageinstead to implement a more idiomatic design.This rename the hierarchies for the implemented codecs.
In addition we try to avoid command message completion handler leaking into each codec and instead we keep this confined in the database socket connection.