Skip to content

Indeterminate PreparedStatement error hidden when inside a transaction #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

Indeterminate PreparedStatement error hidden when inside a transaction #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions vertx-pg-client/src/test/java/io/vertx/pgclient/PreparedStatementTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,14 @@ private <T> void testInferDataType42P18(TestContext ctx, Class<T> type, T value,
ctx.assertEquals("HELLO " + suffix2, str);
}));
}));
PgConnection.connect(vertx, options()).onComplete(ctx.asyncAssertSuccess(conn -> {
conn.begin()
.flatMap(tx -> conn.preparedQuery("SELECT CONCAT('HELLO ', $1)").execute(Tuple.of(value))
.eventually(() -> conn.close())
.onComplete(ctx.asyncAssertFailure(failure -> {
ctx.assertTrue(hasSqlstateCode(failure, "42P18"));
})));
}));
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SocketConnectionBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ private PrepareStatementCommand prepareCommand(ExtendedQueryCommand<?> queryCmd,
}
} else {
Throwable cause = ar.cause();
if (isIndeterminatePreparedStatementError(cause) && !sendParameterTypes) {
if (queryCmd.autoCommit() && isIndeterminatePreparedStatementError(cause) && !sendParameterTypes) {
ChannelHandlerContext ctx = socket.channelHandlerContext();
// We cannot cache this prepared statement because it might be executed with another type
ctx.write(prepareCommand(queryCmd, false, true), ctx.voidPromise());
Expand Down
2 changes: 1 addition & 1 deletion vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/SqlConnectionBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public Future<PreparedStatement> prepare(String sql, PrepareOptions options) {
.compose(
cr -> Future.succeededFuture(PreparedStatementImpl.create(conn, context, cr, autoCommit())),
err -> {
if (conn.isIndeterminatePreparedStatementError(err)) {
if (autoCommit() && conn.isIndeterminatePreparedStatementError(err)) {
return Future.succeededFuture(PreparedStatementImpl.create(conn, context, options, sql, autoCommit()));
} else {
return Future.failedFuture(err);
Expand Down