Skip to content

SqlConnectionPool does not invoke PoolMetrics begin/end methods #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2025
Merged

SqlConnectionPool does not invoke PoolMetrics begin/end methods #1568

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b46ec6d
Add in_use metrics for sql connection pool
adamdickmeiss Nov 10, 2025
2b303a6
Extend queue testing with checks for usage metrics
adamdickmeiss Nov 10, 2025
ac5bef6
Fix MetricsTestBase
tsegismont Nov 12, 2025
fb73c9e
Minor refactoring
tsegismont Nov 12, 2025
89193b5
More robust MetricsTestBase implementation
tsegismont Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/pool/SqlConnectionPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,27 @@ private void dequeueMetric(Object metric) {
}
}

private Object beginMetric() {
if (metrics != null) {
try {
return metrics.begin();
} catch (Exception e) {
//
}
}
return NO_METRICS;
}

private void endMetric(Object metric) {
if (metrics != null && metric != NO_METRICS) {
try {
metrics.end(metric);
} catch (Exception e) {
//
}
}
}

// TODO : try optimize without promise
public <R> void execute(CommandBase<R> cmd, Completable<R> handler) {
ContextInternal context = vertx.getOrCreateContext();
Expand All @@ -191,6 +212,8 @@ public <R> void execute(CommandBase<R> cmd, Completable<R> handler) {
dequeueMetric(metric);
PooledConnection pooled = lease.get();
Connection conn = pooled.conn;
Object useMetric = beginMetric();

Future<R> future;
if (afterAcquire != null) {
future = afterAcquire.apply(conn)
Expand All @@ -202,6 +225,7 @@ public <R> void execute(CommandBase<R> cmd, Completable<R> handler) {
future = pp;
}
return future.andThen(ar -> {
endMetric(useMetric);
pooled.refresh();
lease.recycle();
});
Expand Down Expand Up @@ -244,6 +268,7 @@ public void complete(Lease<PooledConnection> lease, Throwable failure) {
private void handle(Lease<PooledConnection> lease) {
dequeueMetric(metric);
PooledConnection pooled = lease.get();
pooled.usage = beginMetric();
pooled.lease = lease;
handler.succeed(pooled);
}
Expand Down Expand Up @@ -303,6 +328,7 @@ public class PooledConnection implements Connection, Connection.Holder {
private Holder holder;
private Promise<ConnectResult<PooledConnection>> poolCallback;
private Lease<PooledConnection> lease;
private Object usage;
public long idleEvictionTimestamp;
public long lifetimeEvictionTimestamp;

Expand Down Expand Up @@ -443,6 +469,7 @@ private void doClose(Holder holder, Completable<Void> promise) {
}

private void cleanup(Completable<Void> promise) {
endMetric(usage);
Lease<PooledConnection> l = this.lease;
this.lease = null;
refresh();
Expand Down