Skip to content

Conversation

@ZenLiuCN
Copy link

Motivation:

export io.vertx.tracing.opentelemetry that makes OpenTelemetryOptions usable with JPMS.

Conformance:

You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines

@ZenLiuCN
Copy link
Author

This will restore example to usable for JPMS, otherwise it may trigger Javadoc complain about unexports package

  public void ex1() {
    Vertx vertx = Vertx.vertx(new VertxOptions()
      .setTracingOptions(
        new OpenTelemetryOptions()
      )
    );
  }

@tsegismont
Copy link
Member

Thanks @ZenLiuCN

Yes, this is required. But we also need to address the issue with customizing the tracer with the Vert.x Builder. I'll take care of it.

@ZenLiuCN
Copy link
Author

Thanks @ZenLiuCN

Yes, this is required. But we also need to address the issue with customizing the tracer with the Vert.x Builder. I'll take care of it.

Expect the result. Current can only use javadoc legacy mode to skip this condition

@tsegismont
Copy link
Member

Superseded by #98

@tsegismont tsegismont closed this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants