Skip to content

Conversation

@sebthom
Copy link
Member

@sebthom sebthom commented May 29, 2025

This PR integrates the Astro language server into WildWebDeveloper and enables syntax highlighting of *.astro files via TM4E.

image

Why to add Astro support?

Core Web Vitals - Technology Report:

image

GitHub Star History:

image

@sebthom
Copy link
Member Author

sebthom commented May 29, 2025

@vrubezhny can you please request a license review?

@akurtakov
Copy link
Contributor

/request-license-review

@github-actions
Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15323642208

@akurtakov
Copy link
Contributor

akurtakov commented May 29, 2025

@vrubezhny
Copy link
Contributor

We also should probably request the IP Team Review for grammars and language config. But why not to contribute them to tm4e first? (Have anyone checked the existence of astro-grammars in tm4e?)

@sebthom
Copy link
Member Author

sebthom commented May 29, 2025

@vrubezhny In TM4E we only include all the syntax files built into vscode https://github.com/microsoft/vscode/tree/main/extensions and I would like to keep it like that.

@vrubezhny
Copy link
Contributor

vrubezhny commented May 29, 2025

@sebthom do you know a source/project/repo these astro grammars were taken from?

Found in README.md

@vrubezhny
Copy link
Contributor

vrubezhny commented May 29, 2025

An IP Team Review request for astro grammars:

... but probably it'd be much easier just adding [email protected] as a dependency.

@sebthom
Copy link
Member Author

sebthom commented May 29, 2025

@vrubezhny regarding the IP review it is surely better to depend on astro-vscode. I'll check if it makes sense to adjust the PR

@sebthom
Copy link
Member Author

sebthom commented May 29, 2025

@vrubezhny I changed the PR to depend on [email protected] which also pulls in the grammar files. Nice side effect is that the node_modules occupies ca. 10MB less than when using @astro/language-server

@akurtakov could you please request another license review?

@akurtakov
Copy link
Contributor

/request-license-review

@github-actions
Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15340478123

@akurtakov
Copy link
Contributor

@sebthom
Copy link
Member Author

sebthom commented Jun 23, 2025

It looks like all IP requests are approved, no?

@vrubezhny
Copy link
Contributor

/request-license-review

@github-actions
Copy link

/request-license-review

✔️ All licenses already successfully vetted.

Workflow run (with attached summary files):
https://github.com/eclipse-wildwebdeveloper/wildwebdeveloper/actions/runs/15833829677

@vrubezhny
Copy link
Contributor

vrubezhny commented Jun 23, 2025

Yet another IP Team Review request is created for a transitive dependency:

Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@vrubezhny vrubezhny merged commit 49b186a into eclipse-wildwebdeveloper:master Jun 24, 2025
8 of 10 checks passed
@sebthom sebthom deleted the astro branch November 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants