-
Notifications
You must be signed in to change notification settings - Fork 75
Add Astro web framework support #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vrubezhny can you please request a license review? |
|
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
|
We also should probably request the IP Team Review for grammars and language config. But why not to contribute them to tm4e first? (Have anyone checked the existence of |
|
@vrubezhny In TM4E we only include all the syntax files built into vscode https://github.com/microsoft/vscode/tree/main/extensions and I would like to keep it like that. |
|
Found in README.md |
|
An IP Team Review request for astro grammars: ... but probably it'd be much easier just adding |
|
@vrubezhny regarding the IP review it is surely better to depend on astro-vscode. I'll check if it makes sense to adjust the PR |
|
@vrubezhny I changed the PR to depend on @akurtakov could you please request another license review? |
|
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
|
It looks like all IP requests are approved, no? |
|
/request-license-review |
✔️ All licenses already successfully vetted. Workflow run (with attached summary files): |
|
Yet another IP Team Review request is created for a transitive dependency: |
vrubezhny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
49b186a
into
eclipse-wildwebdeveloper:master
This PR integrates the Astro language server into WildWebDeveloper and enables syntax highlighting of *.astro files via TM4E.
Why to add Astro support?
Core Web Vitals - Technology Report:
GitHub Star History: