Skip to content

Conversation

@milyin
Copy link
Contributor

@milyin milyin commented Dec 20, 2025

The binding for the connectivity api introduced in eclipse-zenoh/zenoh#2301

@github-actions
Copy link

PR missing one of the required labels: {'documentation', 'ci', 'internal', 'dependencies', 'bug', 'api-sync', 'enhancement', 'breaking-change', 'new feature'}

@github-actions
Copy link

PR missing one of the required labels: {'enhancement', 'documentation', 'api-sync', 'dependencies', 'internal', 'new feature', 'breaking-change', 'ci', 'bug'}

@github-actions
Copy link

PR missing one of the required labels: {'ci', 'documentation', 'new feature', 'breaking-change', 'dependencies', 'internal', 'api-sync', 'enhancement', 'bug'}

@milyin milyin added the enhancement New feature or request label Jan 13, 2026
@milyin milyin marked this pull request as ready for review January 17, 2026 15:27
/// @return 0 on success, negative value on failure.
#[cfg(feature = "unstable")]
#[no_mangle]
pub extern "C" fn z_declare_background_transport_events_listener(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You check the return code of this function in other places. But does it ever return anything other than Z_OK?

/// @return 0 on success, negative value on failure.
#[cfg(feature = "unstable")]
#[no_mangle]
pub extern "C" fn z_declare_background_link_events_listener(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. Does it ever return anything other than Z_OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants