Skip to content

Conversation

@evshary
Copy link
Contributor

@evshary evshary commented Dec 17, 2025

Solve #2142

We added the EndPoints to accept a single EndPoint or EndPoint vector.

To test the multiple connections:

RUST_LOG=zenoh_transport::unicast::establishment=debug zenohd --cfg=transport/unicast/max_links:2
RUST_LOG=zenoh_transport::unicast::establishment=debug z_sub --cfg=transport/unicast/max_links:2 -m client -e tcp/127.0.0.1:7447?rel=1,tcp/127.0.0.1:7447?rel=0

Note that we use the , as the delimiter to split the multiple links.

@github-actions
Copy link

PR missing one of the required labels: {'dependencies', 'breaking-change', 'enhancement', 'api-sync', 'bug', 'internal', 'ci', 'new feature', 'documentation'}

@evshary evshary added the bug Something isn't working label Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 73.09942% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.71%. Comparing base (f33fe8c) to head (d9095ba).
⚠️ Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
zenoh/src/net/runtime/orchestrator.rs 73.77% 16 Missing ⚠️
commons/zenoh-protocol/src/core/endpoint.rs 75.80% 15 Missing ⚠️
commons/zenoh-config/src/mode_dependent.rs 60.86% 9 Missing ⚠️
commons/zenoh-config/src/lib.rs 79.16% 5 Missing ⚠️
zenohd/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   72.98%   72.71%   -0.28%     
==========================================
  Files         387      387              
  Lines       62160    62089      -71     
==========================================
- Hits        45370    45145     -225     
- Misses      16790    16944     +154     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
}

if !args.connect.is_empty() {
// Able to parse multiple endpoints, e.g. "tcp/127.0.0.1:7447?rel=0,tcp/127.0.0.1:7447?rel=1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change in behavior.
Coma separated values were already accepted here and were the equivalent of passing multiple -e arguments.
Let's decide if:

  • we assume this behavior change and add this in a minor release
  • find another separator for this case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer the first one, while the second one will make usage complicated.
However, it's still fine with me if we decide on the second one.

@OlivierHecart
Copy link
Contributor

I also realize that we had plans to create locator groups for peers, where peer connect to a single endpoint of each group. We need to decide if this is still something we consider and how to articulate that with the multilink thing here.

@OlivierHecart
Copy link
Contributor

Another point, I don't see any changes in DEFAULT_CONFIG.json5. It would be good to have this roughly documented there.

@evshary
Copy link
Contributor Author

evshary commented Jan 6, 2026

Another point, I don't see any changes in DEFAULT_CONFIG.json5. It would be good to have this roughly documented there.

I thought it would make the description too complicated, so I just skipped that.
I've added it to the config now.

@OlivierHecart OlivierHecart requested review from fuzzypixelz and removed request for fuzzypixelz January 6, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants