-
Notifications
You must be signed in to change notification settings - Fork 229
Support multiple connections in the client mode. #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ChenYing Kuo <[email protected]>
|
PR missing one of the required labels: {'dependencies', 'breaking-change', 'enhancement', 'api-sync', 'bug', 'internal', 'ci', 'new feature', 'documentation'} |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2320 +/- ##
==========================================
- Coverage 72.98% 72.71% -0.28%
==========================================
Files 387 387
Lines 62160 62089 -71
==========================================
- Hits 45370 45145 -225
- Misses 16790 16944 +154 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
Signed-off-by: ChenYing Kuo <[email protected]>
| } | ||
|
|
||
| if !args.connect.is_empty() { | ||
| // Able to parse multiple endpoints, e.g. "tcp/127.0.0.1:7447?rel=0,tcp/127.0.0.1:7447?rel=1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change in behavior.
Coma separated values were already accepted here and were the equivalent of passing multiple -e arguments.
Let's decide if:
- we assume this behavior change and add this in a minor release
- find another separator for this case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer the first one, while the second one will make usage complicated.
However, it's still fine with me if we decide on the second one.
|
I also realize that we had plans to create locator groups for peers, where peer connect to a single endpoint of each group. We need to decide if this is still something we consider and how to articulate that with the multilink thing here. |
|
Another point, I don't see any changes in |
Signed-off-by: ChenYing Kuo <[email protected]>
I thought it would make the description too complicated, so I just skipped that. |
Solve #2142
We added the
EndPointsto accept a singleEndPointorEndPointvector.To test the multiple connections:
Note that we use the
,as the delimiter to split the multiple links.