Skip to content

Fix namespace filter to use keyword field for exact matching#1539

Closed
VijayabaskarR-06 wants to merge 2 commits intoeclipse:masterfrom
VijayabaskarR-06:fix-namespace-exact-match
Closed

Fix namespace filter to use keyword field for exact matching#1539
VijayabaskarR-06 wants to merge 2 commits intoeclipse:masterfrom
VijayabaskarR-06:fix-namespace-exact-match

Conversation

@VijayabaskarR-06
Copy link

The namespace (publisher) filter used a term query on an analyzed field,
which caused partial matches (e.g. publisher:vscode matching ms-vscode).

This change switches the filter to the non-analyzed keyword field and
adds a regression test to ensure exact matching.

Fixes #1522

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

can you please sign the eca, see details here https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1539.

Also could you work on a integration test to validate that the fix is working as expected?

@VijayabaskarR-06
Copy link
Author

@netomi Thanks for the review!

I’ve signed the Eclipse Contributor Agreement; it should propagate shortly. Please let me know if it’s still not visible from your side.

Sure, I can work on an integration test to validate that the namespace filter only matches exact publishers (e.g. publisher:vscode does not match ms-vscode). I’ll add this to the current PR.

@VijayabaskarR-06
Copy link
Author

VijayabaskarR-06 commented Jan 12, 2026

Thanks for the note! I’ve now signed the ECA and added an integration test that verifies the namespace filter only matches exact values (e.g. vscode does not match ms-vscode) and also mentioned the clear working of the code . Please let me know if you’d like the test adjusted.

@netomi
Copy link
Contributor

netomi commented Jan 12, 2026

the test is in the actual main source path and it is missing basically any import.

so I wonder how this PR was generated.

@VijayabaskarR-06
Copy link
Author

VijayabaskarR-06 commented Jan 13, 2026

@netomi Thanks for pointing this out — you’re right.

I thought the imports were automatically held in the test, but the test was mistakenly added under the main source path. I’ll move it to
server/src/test/java and ensure all required imports are explicitly included.
I’ll push an updated commit shortly.

@VijayabaskarR-06 VijayabaskarR-06 force-pushed the fix-namespace-exact-match branch 2 times, most recently from fe5b8fb to 71a39be Compare January 13, 2026 06:46
@VijayabaskarR-06
Copy link
Author

I observed that application.html.erb was loading the application stylesheet twice. As a result, there were needless duplicate CSS requests. The fix eliminates the unnecessary inclusion, guaranteeing that styles load only once and maintaining a tidy and effective layout.

@netomi netomi closed this Jan 13, 2026
@VijayabaskarR-06 VijayabaskarR-06 deleted the fix-namespace-exact-match branch January 13, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by publisher seems to be broken

2 participants