Fix namespace filter to use keyword field for exact matching#1539
Fix namespace filter to use keyword field for exact matching#1539VijayabaskarR-06 wants to merge 2 commits intoeclipse:masterfrom
Conversation
|
can you please sign the eca, see details here https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1539. Also could you work on a integration test to validate that the fix is working as expected? |
|
@netomi Thanks for the review! I’ve signed the Eclipse Contributor Agreement; it should propagate shortly. Please let me know if it’s still not visible from your side. Sure, I can work on an integration test to validate that the namespace filter only matches exact publishers (e.g. publisher:vscode does not match ms-vscode). I’ll add this to the current PR. |
|
Thanks for the note! I’ve now signed the ECA and added an integration test that verifies the namespace filter only matches exact values (e.g. |
|
the test is in the actual main source path and it is missing basically any import. so I wonder how this PR was generated. |
|
@netomi Thanks for pointing this out — you’re right. I thought the imports were automatically held in the test, but the test was mistakenly added under the main source path. I’ll move it to |
fe5b8fb to
71a39be
Compare
|
I observed that application.html.erb was loading the application stylesheet twice. As a result, there were needless duplicate CSS requests. The fix eliminates the unnecessary inclusion, guaranteeing that styles load only once and maintaining a tidy and effective layout. |
The namespace (publisher) filter used a term query on an analyzed field,
which caused partial matches (e.g. publisher:vscode matching ms-vscode).
This change switches the filter to the non-analyzed keyword field and
adds a regression test to ensure exact matching.
Fixes #1522